Commit @6f62307973748e5c59fbcbb38089b2bb94e45e7c

Y
List All
Feedback
- This Project
- All Projects

윤영준 2023-06-29

something is weird about this gamma correction

@6f62307973748e5c59fbcbb38089b2bb94e45e7c

6d3bc38

6f62307

model/Generator.py

--- model/Generator.py

+++ model/Generator.py


         return ret
 
     def binary_diff_mask(self, clean, dirty, thresold=0.1):
-        clean = torch.pow(clean, 2.2)
-        dirty = torch.pow(dirty, 2.2)
+        # this parts corrects gamma, and always remember, sRGB values are not in linear scale with lights intensity
+        clean = torch.pow(clean, 0.45)
+        dirty = torch.pow(dirty, 0.45)
         diff = torch.abs(clean - dirty)
         diff = torch.sum(diff, dim=1)
-        # this line is certainly cause problem for quantization
-        # like, hardcoding it, what could go wrong?
+
         bin_diff = (diff > thresold).to(clean.dtype)
 
         return bin_diff

Add a comment

Open 0
Closed 0

List

...	...	@@ -35,12 +35,12 @@
35	35	return ret
36	36
37	37	def binary_diff_mask(self, clean, dirty, thresold=0.1):
38		- clean = torch.pow(clean, 2.2)
39		- dirty = torch.pow(dirty, 2.2)
	38	+ # this parts corrects gamma, and always remember, sRGB values are not in linear scale with lights intensity
	39	+ clean = torch.pow(clean, 0.45)
	40	+ dirty = torch.pow(dirty, 0.45)
40	41	diff = torch.abs(clean - dirty)
41	42	diff = torch.sum(diff, dim=1)
42		- # this line is certainly cause problem for quantization
43		- # like, hardcoding it, what could go wrong?
	43	+
44	44	bin_diff = (diff > thresold).to(clean.dtype)
45	45
46	46	return bin_diff

Delete comment